Return `CStr` in `goblin::strtab::Strtab` instead of `str`
Open
- Dominant language
- Rust
- Stars
- 1.5k
- Forks
- 202
- PR merge metrics
- No merged PRs in 30d
Description
There is no way to get access to null-terminated C strings that are **not** valid UTF-8, through `goblin::strtab::Strtab`. `Strtab.get()` and `Strtab.get_at()` should return `Option<&CStr>` instead of optional UTF-8 `str`s.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating goblin::strtab::Strtab and the get() and get_at() methods, then inspect their callers and existing tests. The change is done when both methods expose null-terminated strings that are not valid UTF-8 through Option<&CStr>, with affected callers and tests updated accordingly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- reverse-engineering
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100