m4b / m4b/goblin

is_import() incorrectly checks st_value == 0

Open
#288 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1.5k
Forks
202
PR merge metrics
No merged PRs in 30d

Description

You want to be checking whether it's global/weak and has a shndx of 0 (SHN_UNDEF)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating is_import() in the Rust ELF parsing code and inspect its current symbol-value and section-index checks. Confirm the behavior for global or weak symbols with SHN_UNDEF, then add or update focused coverage if the surrounding code has tests. Done means is_import() uses the intended binding and section-index conditions instead of st_value == 0.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
reverse-engineering
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.