lynndylanhurley / lynndylanhurley/devise_token_auth
Invalid user signs in but no header tokens are returned
Open
- Dominant language
- Ruby
- Stars
- 3.6k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
I am not sure if this is the intended functionality, but when a user signs in but has invalid data the user data will still be returned. The access token headers however are not returned and this failure happens silently. An error should be raised if the user is invalid. See the update_auth_headers function.
Contributor guide
Research direction
Start by reading the update_auth_headers function and trace the invalid sign-in path described in the issue. Reproduce the case with invalid user data, then verify that it raises an error instead of silently returning user data without access-token headers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- api, authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100