lynndylanhurley / lynndylanhurley/devise_token_auth

auth_headers are not merged into response.headers if is_batch_request

Open
#541 5 comments 1 reaction 0 assignees View on GitHub
Dominant language
Ruby
Stars
3.6k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

if is_batch_request, auth_headers are generated but they are not merged into response headers.

https://github.com/lynndylanhurley/devise_token_auth/blob/master/app/controllers/devise_token_auth/concerns/set_user_by_token.rb#L104

merging auth_headers should be in any cases.

Contributor guide

Open the contributing guide

Research direction

Start in app/controllers/devise_token_auth/concerns/set_user_by_token.rb around line 104, where auth_headers are generated for batch requests. Trace how response.headers is handled in both batch and non-batch cases, and verify that auth_headers are merged in every case.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
api, authentication
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.