lynndylanhurley / lynndylanhurley/devise_token_auth
Model concern breaks devise reconfirmable
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 3.6k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
Because the model concern sets email_changed? to always be false, Devise's [reconfirmable](https://github.com/plataformatec/devise/blob/9f37b6eff7b4f9b0441be5a687b3091db82befc4/lib/devise/models/confirmable.rb#L256) portion of :confirmable will never trigger. I found [this](https://github.com/lynndylanhurley/devise_token_auth/issues/229) issue saying that it was necessary to override the redirect_url. Does that mean that breaking reconfirmable is an unfortunate but necessary side effect?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the model concern mentioned in the issue and compare its email_changed? behavior with Devise's confirmable.rb reconfirmable section at the linked line. Check the referenced redirect_url discussion and determine whether reconfirmable can still trigger without breaking the token-auth flow; done means the behavior and any required redirect handling are verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- api, authentication
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100