lynndylanhurley / lynndylanhurley/devise_token_auth
`ConfirmationsController` doesn't use `redirect_options` properly
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 3.6k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/lynndylanhurley/devise_token_auth/blob/bcdc3a5964086b6a08f3f98eb878a107af1334da/app/controllers/devise_token_auth/confirmations_controller.rb#L30
I think the above line should be
```ruby
redirect_to DeviseTokenAuth::Url.generate(redirect_url, { account_confirmation_success: false }.merge(redirect_options))
```
because right now `redirect_options` are not passed as query params.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in app/controllers/devise_token_auth/confirmations_controller.rb at the linked line and inspect how redirect_options is passed to the generated confirmation URL. Verify that the redirect options appear as query parameters and confirm the relevant confirmation redirect behavior before marking the issue done.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- api, authentication
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100