lynndylanhurley / lynndylanhurley/devise_token_auth

0.1.43 does not return client and access-token with each response

Open
#1,159 29 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
3.6k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

The latest version now wipes access-token and client for subsequent API requests:

https://github.com/lynndylanhurley/devise_token_auth/blob/00fa5f4507da806f66664787745086ce404d95b4/app/controllers/devise_token_auth/concerns/set_user_by_token.rb#L18

```ruby
# keep track of request duration
def set_request_start
@request_started_at = Time.zone.now
@used_auth_by_token = true

# initialize instance variables
@client_id = nil
@resource = nil
@token = nil
@is_batch_request = nil
end
```

The way we had our application set up was relying on those access tokens being returned as they were in previous releases.

Why was this change added? The commit only mentions passing tests: https://github.com/lynndylanhurley/devise_token_auth/commit/bdcd05e284e7fd0774005248a3239bfc889824c4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with app/controllers/devise_token_auth/concerns/set_user_by_token.rb at the referenced initialization and inspect commit bdcd05e284e7fd0774005248a3239bfc889824c4. Compare the response behavior with the previous release and review the tests that commit changed or relied on. Done means the intended client and access-token behavior is established and covered by regression tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
api, authentication
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.