lyft / lyft/python-blessclient

Dont add to ssh-agent unless specified

Open
#27 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
117
Forks
31
PR merge metrics
No merged PRs in 30d

Description

I would suggest implementing a parameter that allows stopping bless from adding the Identity file to `ssh-agent`.
Namely this lines: https://github.com/lyft/python-blessclient/blob/master/blessclient/client.py#L594-L597

Given a config like:
```
Match exec "env | grep -q BLESS_COMPLETE || /Users/stype/blessclient/blessclient.run --gui --host '%h'"
IdentityFile ~/.ssh/blessid
```
this is not required and could interfere with other credentials.

I think this is required when doing a wrapper around the `ssh` command but in that case its easy to toggle on in the script.

If this is accepted I can create a PR to cleanup/implement this.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in blessclient/client.py at lines 594-597 and trace how the client options are passed to the SSH-agent handling. Add a parameter that disables adding the Identity file while preserving the existing behavior by default; done means the wrapper use case can opt out without affecting other credentials.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
authentication, security
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.