lyft / lyft/lyft-android-sdk

Remove dependency on org.jetbrains:annotations-java5

Open
#24 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
72
Forks
21
PR merge metrics
No merged PRs in 30d

Description

There are several other annotations packages that do not cause packaging conflicts when used with standard jetbrains annotations. For example, you could use the more standard `org.jetbrains:annotations` or the `androidx.annotation:annotation` packages.

Example of packaging error seen when using this SDK with a build environment that also uses the `org.jetbrains:annotations` package:

```
> Duplicate class org.intellij.lang.annotations.Flow found in modules jetified-annotations-16.0.1 (org.jetbrains:annotations:16.0.1) and jetified-annotations-java5-15.0 (org.jetbrains:annotations-java5:15.0)
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the SDK's dependency declarations for org.jetbrains:annotations-java5 and inspect how the Android package is assembled. Replace the conflicting dependency with a compatible annotations package, then verify that a build using standard org.jetbrains:annotations no longer reports duplicate classes.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
build-system, mobile
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.