lyft / lyft/lyft-android-sdk

Deeplink parameter makes Lyft app crash

Open
#11 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
72
Forks
21
PR merge metrics
No merged PRs in 30d

Description

If I specify only `pickup[address]` the Lyft app crashes with this error:

```
06-18 23:06:50.786 27039-27039/? E/AndroidRuntime: FATAL EXCEPTION: main
Process: me.lyft.android, PID: 27039
java.lang.RuntimeException: Unable to resume activity {me.lyft.android/me.lyft.android.ui.MainActivity}: java.lang.NullPointerException
at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3103)
at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3134)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1388)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
Caused by: java.lang.NullPointerException
at com.lyft.common.Objects.c(SourceFile:71)
at me.lyft.android.ui.RideTypesDeepLinkRoute.forwardGeocode(SourceFile:178)
at me.lyft.android.ui.RideTypesDeepLinkRoute.route(SourceFile:97)
at com.lyft.android.deeplinks.GenericDeepLinkRouter.routeAction(SourceFile:63)
at com.lyft.android.deeplinks.GenericDeepLinkRouter.routeDeepLink(SourceFile:18)
at com.lyft.android.deeplinks.DeepLinkManager.a(SourceFile:68)
at com.lyft.android.deeplinks.DeepLinkManager.a(SourceFile:22)
at me.lyft.android.ui.MainActivity.checkForDeepLink(SourceFile:496)
at me.lyft.android.ui.MainActivity.onResume(SourceFile:326)
at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1258)
at android.app.Activity.performResume(Activity.java:6327)
```

Here is the log on my app (just before the crash):

```
I/Taxi: redirect to lyft://ridetype?id=lyft&pickup[address]=via borgo palazzo 1, Bergamo&destination[latitude]=45.467237&destination[longitude]=9.189705
I/ActivityManager: START u0 {act=android.intent.action.VIEW dat=lyft://ridetype?id=lyft&pickup[latitude]=via borgo palazzo 1, Bergamo&destination[latitude]=45.467237&destination[longitude]=9.189705 flg=0x10000000 cmp=me.lyft.android/.ui.MainActivity} from uid 10085 on display 0
```

I know it's not strictly related to this SDK but I didn't know where to open this elsewhere.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported deeplink with only pickup[address] and compare it with the logged redirect and Android stack trace. The trace names MainActivity, DeepLinkManager, GenericDeepLinkRouter, and RideTypesDeepLinkRoute, but the report does not identify a repository file or test; confirm whether this SDK owns the crash before defining a fix and acceptance test.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.