lyft / lyft/flinkk8soperator

CRD schema required for object validation in newer Kubernetes releases

Open
#253 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
581
Forks
153
PR merge metrics
No merged PRs in 30d

Description

Newer versions of Kubernetes (e.g. 1.20+) perform type-validation of data written to the CRD. The CRD for the Flink operator currently does not define a schema for the `status` object. This leads to Flink applications never advancing in the state machine, as their updated state cannot be written.

This leads to logs like the following, where the app never advances beyond the `CreatingCluster` state:
```
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Handling state for application","ts":"2022-03-11T04:21:38Z"}
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Jobmanager service already exists","ts":"2022-03-11T04:21:38Z"}
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Logged Normal event: CreatingCluster: Creating Flink cluster for deploy b6178add","ts":"2022-03-11T04:21:38Z"}
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Handling state for application","ts":"2022-03-11T04:21:38Z"}
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Jobmanager deployment already exists","ts":"2022-03-11T04:21:38Z"}
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Jobmanager service already exists","ts":"2022-03-11T04:21:38Z"}
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Versioned Jobmanager service already exists","ts":"2022-03-11T04:21:38Z"}
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Taskmanager deployment already exists","ts":"2022-03-11T04:21:38Z"}
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Handling state for application","ts":"2022-03-11T04:22:07Z"}
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Jobmanager deployment already exists","ts":"2022-03-11T04:22:07Z"}
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Jobmanager service already exists","ts":"2022-03-11T04:22:07Z"}
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Versioned Jobmanager service already exists","ts":"2022-03-11T04:22:07Z"}
{"json":{"app_name":"flink-test-app","ns":"aws-us-east-1-dos1","phase":""},"level":"info","msg":"Taskmanager deployment already exists","ts":"2022-03-11T04:22:07Z"}
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the Flink operator's CRD definition and inspect how the status object is represented. Reproduce the issue on a Kubernetes release with CRD type validation enabled, then verify that status updates are accepted and applications advance beyond CreatingCluster.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
devops, infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.