lyft / lyft/Lyft-iOS-sdk

iOS SDK broken for all calls in Canada (as well as non-US regions)

Open
#21 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
46
Forks
22
PR merge metrics
No merged PRs in 30d

Description

The Lyft API is giving an invalid error when invoked from the iOS SDK on any of the ride type, estimates and ETA routes. Instead of giving back results, it errors saying there is no service in the area (Toronto, Canada).

**EXAMPLE**:
GET request to https://api.lyft.com/v1/eta?lat=43.6479328&lng=-79.3778371

**ERROR**:
```no_service_in_area```
```The requested location is not inside a Lyft service area```

**This is what the iOS SDK currently sends (BROKEN):**
[![enter image description here][1]][1]

When invoking the API manually, the error doesn't happen if the user agent which the SDK sends out is omitted ('User-Agent' value of 'lyft-mobile-sdk:ios::1.0.6')

**Removing 'User-Agent' works:**
[![enter image description here][2]][2]

Confirmed that forking the iOS SDK and removing User-Agent removes this error (commit here: https://github.com/marchy/Lyft-iOS-sdk/commit/c23811f890e4881ef0e6789b6392b1a38db1334d) – thus the bug is confirmed to be on the API front.

**This is a critical break and affects all calls made from the iOS SDK** (at least up here in Canada – and perhaps other non-US regions).

[1]: https://i.stack.imgur.com/NTfwl.png
[2]: https://i.stack.imgur.com/AZQI0.png

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The report names no repository file or test; begin by reproducing the GET /v1/eta example for Toronto and inspect where the iOS SDK adds the User-Agent value. Compare the SDK request with the manual request and the reported fork commit, then verify that ride type, estimates, and ETA calls return results for non-US regions without the no_service_in_area error.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
api, mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.