Gulp removes comment because of ';' before seaf
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 959
- Forks
- 179
- PR merge metrics
- No merged PRs in 30d
Description
If you use gulp and want to minify your files you have to remove the ';'-char which should prevent accidently unclosed previous function calls. Otherwise the whole comment would be stripped out which is really bad in that case (MIT license). The option in gulp config 'preserveComments: {'license'}' was set but is ignored in that case.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Gulp minification configuration and reproduce the issue using a semicolon before the reported function call while preserveComments is set to keep licenses. Trace how comments are handled during minification. Done means the MIT license comment remains in the minified output without requiring the semicolon to be removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100