sinuous/map v0.30.0 removes node unexpectedly.
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
When `[ "foo", "BAR", "baz" ]` is transformed to `[ "BAR" ]`, all elements will be deleted then `"BAR"` will be recreated.
In version 0.27.6, `[ "foo", "BAR", "baz" ]` is transformed to `[ "BAR" ]` by deleting `"foo"` and `"baz"`, which seems more reasonable.
Here is the code demonstrates this situation. https://codepen.io/j-sen/pen/MWzdBdP
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked CodePen reproduction and compare the behavior of sinuous/map in v0.27.6 and v0.30.0. Trace the relevant map implementation and existing tests, if present; done means transforming ["foo", "BAR", "baz"] to ["BAR"] removes only the nonmatching elements without recreating "BAR".
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100