Potentially buggy test
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
The following test looks buggy to me:
https://github.com/luwes/sinuous/blob/ece2c65c19939ec5742f999cfba6c83295c58118/packages/sinuous/observable/test/child.js#L230-L269
At line 264 we are basically just updating the observable from -1 to 0. The D computed depends only on this observable and returns observable+10. Then at line 266 we say the D computed shouldn't have run, why shouldn't it?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/sinuous/observable/test/child.js at lines 230-269 and trace the observable and computed values around lines 264-266. Check the observable implementation and related tests to determine whether D should rerun when its dependency changes. Done means the test expectation and observable behavior agree, with the relevant test passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100