Resetting the active root only if the currently disposed one is the active one
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
I think there's a bug here:
https://github.com/luwes/sinuous/blob/ece2c65c19939ec5742f999cfba6c83295c58118/packages/sinuous/observable/src/observable.js#L28
Shouldn't it reset the current root only if the one that got disposed is the active one? Otherwise this would break with nested roots, I think.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/sinuous/observable/src/observable.js at line 28 and trace how disposal updates the active root, especially when roots are nested. Check the existing observable tests for disposal coverage and add a regression case if appropriate. Done means disposing a non-active root does not replace the currently active root, while the relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100