luwes / luwes/js-diff-benchmark
won't run in Win10 :/
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 69
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
$ npm test
> js-diff-benchmark@1.0.0 test D:\doc\prog\learn\js\vdom\js-diff-benchmark
> node --expose-gc src/bench.js
D:\doc\prog\learn\js\vdom\js-diff-benchmark\src\utils.js:29
mutations.push(`remove: drop(${oldNode.textContent})`);
^
TypeError: Cannot read property 'textContent' of undefined
at Dommy.container.removeChild (D:\doc\prog\learn\js\vdom\js-diff-benchmark\src\utils.js:29:44)
at module.exports (D:\doc\prog\learn\js\vdom\js-diff-benchmark\libs\spect.js:20:18)
at create1000 (D:\doc\prog\learn\js\vdom\js-diff-benchmark\src\utils.js:82:14)
at D:\doc\prog\learn\js\vdom\js-diff-benchmark\src\bench.js:75:20
at Array.forEach (<anonymous>)
at Object.<anonymous> (D:\doc\prog\learn\js\vdom\js-diff-benchmark\src\bench.js:58:6)
at Module._compile (internal/modules/cjs/loader.js:1147:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1167:10)
at Module.load (internal/modules/cjs/loader.js:996:32)
at Function.Module._load (internal/modules/cjs/loader.js:896:14)
TY :)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure with npm test on Windows 10 and start at src/utils.js:29, where removeChild reads oldNode.textContent. Trace the call through libs/spect.js and src/bench.js, then verify that the benchmark completes without the TypeError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100