lupine-dev / lupine-dev/ToneMatrixRedux

Multi-instrument support

Open
#17 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
106
Forks
28
PR merge metrics
No merged PRs in 30d

Description

There could be an `Instrument` interface that is implemented by instrument types such as `RenderedSynthInstrument`, `RealtimeSynthInstrument`, and `RealInstrument`. (There's not a great built-in way to do interfaces in JS, so "interface" is purely conceptual here.)

These instruments would be managed by the `NotePlayer` class.

* `PrerenderedSynthInstrument` would be how the code currently works - pre-render a scale of notes into an audio buffer, then play the buffer piecemeal using multiple voices as notes are requested.

* `RealtimeSynthInstrument` would schedule and play synth notes in real time, the way the `Tone.js` library works by default.

* `RealInstrument` would load in a set of audio files (or an audio sprite) from URL(s). This could allow a ToneMatrix instrument to be backed by recordings of real instruments such as piano.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the NotePlayer class and the existing pre-rendered synth path. Read how current notes and voices are managed, then compare the proposed PrerenderedSynthInstrument, RealtimeSynthInstrument, and RealInstrument responsibilities. Done would mean a decided instrument abstraction that NotePlayer can manage across the proposed playback modes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
audio-video-rtc
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.