lundegaard / lundegaard/validarium

`translateResult` cannot handle { message, messageValues }

Open
#30 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
28
Forks
9
PR merge metrics
No merged PRs in 30d

Description

although line [isIntlMessageWithArgs, ({ message, messageValues }) => formatMessage(message, messageValues)], should technically support it, pickByNotNil ruins everything :(

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at translateResult and inspect how pickByNotNil processes the { message, messageValues } shape before the formatMessage call. Reproduce the reported input and trace which value is removed; done means translateResult preserves the values needed by formatMessage and the behavior is covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.