luminus-framework / luminus-framework/luminus

A bit outdated documentation on Ring middleware?

Open
#272 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
CSS
Stars
626
Forks
122
PR merge metrics
No merged PRs in 30d

Description

https://luminusweb.com/docs/routes.html

> We can now wrap the route groups we wish to be private using the wrap-restricted middleware in the .handler/app function:
>
> (def app
> (-> (routes
> (-> home-routes
> (wrap-routes middleware/wrap-csrf)
> (wrap-routes middleware/wrap-restricted))
> base-routes)
> middleware/wrap-base))
>

I might be wrong but at first sight it looks like Compojure was used as a dependency at some point in Luminus. This is where the `wrap-routes` function is from.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the routes.html documentation at the linked URL and compare the quoted wrap-routes example with the current Luminus middleware usage. Verify the claim about Compojure and update the passage so it accurately reflects the current dependency and route-group wrapping approach.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.