luminus-framework / luminus-framework/luminus

Example code for setting cookies

Open
#142 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
CSS
Stars
626
Forks
122
PR merge metrics
No merged PRs in 30d

Description

The [documentation for cookies](https://github.com/luminus-framework/luminus/blob/master/resources/md/sessions_cookies.md#cookies) shows that cookies can be set like this:

``` clj
(-> "cookie set" response (update-in [:cookies "username" :value] "Alice"))
```

I don't think `(response "cookie set")` makes sense and `"Alice"` cannot be used as a function for `update-in`. I think the example can be simply this:

``` clj
(assoc-in response [:cookies "username" :value] "Alice")
```

Do I understand it correctly?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open resources/md/sessions_cookies.md at the cookies section and review the surrounding examples and terminology. Verify the proposed cookie-update expression against the documented response structure, then update the example so it is valid and consistent with the guide. Done means the snippet can be followed without calling a string as a function.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.