luminus-framework / luminus-framework/guestbook

missing "guestbook.routes.home" call

Open
#16 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
41
Forks
17
PR merge metrics
No merged PRs in 30d

Description

I must be wrong here because someone would have caught this before. So, I would appreciate some clarification in my logic.
//Lawrence

guestbook.routes.home calls "db/save-message!" but [guestbook.db.core :as db] does not contain the function "save-message!".

(defn save-message! [{:keys [params]}](if-let [errors %28validate-message params%29]
%28-> %28response/found)
(assoc :flash (assoc params :errors errors)))
(do
(db/save-message!
(assoc params :timestamp (java.util.Date.)))
(response/found "/"))))

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the guestbook.routes.home code shown in the issue and the guestbook.db.core namespace it references. Trace the save-message! call and confirm whether the database namespace defines it or whether the example is otherwise inconsistent. Done means the reported missing-function concern is resolved and the relevant guestbook flow works as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
backend, database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.