lukejacksonn / lukejacksonn/ijk

broken with superfine

Open
#24 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
470
Forks
11
PR merge metrics
No merged PRs in 30d

Description

ultradom is now superfine, it returns to the `'name, 'props', 'children'` signature, and it requires text nodes to be wrapped in a vnode: https://github.com/jorgebucaran/superfine/blob/master/src/index.js#L368-L381

```js
var createVNode = function(name, props, children, element, key, type) {
return {
name: name,
props: props,
children: children,
element: element,
key: key,
type: type
}
}

var createTextVNode = function(text, element) {
return createVNode(text, EMPTY_OBJECT, EMPTY_ARRAY, element, null, TEXT_NODE)
}
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by comparing ijk's virtual-node handling with superfine's src/index.js at the linked lines, focusing on the documented name, props, children signature and text-node representation. Done means ijk works with the current superfine behavior, including wrapped text nodes; no test file is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.