lukejacksonn / lukejacksonn/GreedyNav

`check()` doesn't seem to run properly on page load

Open
#18 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
236
Forks
50
PR merge metrics
No merged PRs in 30d

Description

Initially when the page loads, there can be overlapping navigation items (the A in about is cut off):
![img_3804](https://user-images.githubusercontent.com/10042268/51813805-1cb64e00-226d-11e9-91fd-5343c2d421fa.jpeg)

However, if I scroll down and then back up, an event must get triggered because the navigation items stop overlapping:
![img_3805](https://user-images.githubusercontent.com/10042268/51813810-20e26b80-226d-11e9-98bc-ba9c6b3125d3.jpeg)

I have only been able to reproduce this issue on mobile.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the check() entry point and reproducing the issue on a mobile viewport during the initial page load. Compare the initial state with the state after scrolling down and back up; done means navigation items do not overlap on first load and still behave correctly after scrolling.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.