lukeed / lukeed/webpack-critical
Migrate to `critical` or `penthouse` directly?
Open
Nobody has claimed this yet.
maybe
- Dominant language
- JavaScript
- Stars
- 110
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
Now that penthouse has migrated to Puppeteer, it might be worthwhile to use it (or critical) instead of some of critical's sub-dependencies.
Benefits
- Solve #1 for free
- Viewport (width x height) comparison
- Configurable Viewport
Hesitations
- Still entails a large dependency download
- Big "overhead" for only viewport calculation
- maybe not that important to most people?
- (generally) not much excess/waste without viewport
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the current dependency usage in webpack-critical and compare whether direct use of penthouse or critical addresses the viewport-related concerns described here and in issue #1. Done requires a settled migration direction and an implementation plan; this issue names no files or tests to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100