lukeed / lukeed/sockette

Sockette.close can unexpectedly clear other timeouts/intervals

Open
#66 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2.5k
Forks
79
PR merge metrics
No merged PRs in 30d

Description

Since the first call to `window.setTimeout` or `window.setInterval` is returning handle with ID `1` calling `Sockette.close` would unexpectedly clear that timeout, because `timer=1` is still a valid handle ID.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Sockette.close implementation and its timer initialization, then reproduce the case where the first window.setTimeout or window.setInterval handle has ID 1. Done means closing Sockette no longer clears an unrelated timeout or interval.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.