Routes with trailing slashes should be parsed as different to routes without
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 599
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Description
Please see https://github.com/lukeed/trouter/issues/25
The issue stems from `\/?` being matched at the end of all patterns in regexparam: https://github.com/aral/regexparam/blob/master/src/index.js#L28
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/index.js around line 28 and the linked trouter issue to understand the expected routing behavior. Compare how patterns with and without trailing slashes are converted to regular expressions, then verify that the resulting route matches are distinct without changing other pattern behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100