lukeed / lukeed/matchit

Plans to allow regex for dynamic params?

Open
#9 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
323
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Hello!

Thanks for creating `matchit`, it's simple and clean.

I am checking to see if you will accept a PR, which allows the support for regex for dynamic parameters. For example:

```js
parse('/user/:id', {
id: '[0-9]+'
})
```

Unlike `path-to-regexp`, this change will not allow regex with in the pattern. However, one can define it just for the dynamic parameters.

I am happy to share a Pull request for same, but wanted to know, if you would like to have this as an addition or not?

Contributor guide

No contributing guide indexed for this repository

Research direction

No implementation files, tests, or entry points are named. Review the existing parse API and its documentation first, then determine how dynamic-parameter regex options should be specified and tested; done means the example pattern accepts numeric ids without allowing regex directly in the route pattern.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.