Wrong result with nested sets
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.5k
- Forks
- 36
- PR merge metrics
- No merged PRs in 30d
Description
import { dequal } from 'dequal';
const set1 = new Set([
new Set([1, 2]),
new Set([1, 2]),
]);
const set2 = new Set([
new Set([1, 2]),
new Set([1, 4]),
]);
console.log('dequal:', dequal(set1, set2)); //true
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Run the JavaScript reproduction from the issue and locate the nested Set comparison logic in the dequal source. Add a regression test covering the two Set values shown, then verify that the unequal nested Sets are no longer reported as equal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100