Infinite loop when both arguments have cycles
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.5k
- Forks
- 36
- PR merge metrics
- No merged PRs in 30d
Description
If both arguments have cycles, like if you're trying to compare doubly-linked lists, dequal goes into an infinite loop.
repro:
const a: any = {}, b: any = {};
a.next = b;
b.previous = a;
const c: any = {}, d: any = {};
c.next = d;
d.previous = c;
dequal(a, c);
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the dequal call in the reproduction and trace the object-comparison entry point. Add regression coverage for two mutually cyclic object pairs, then verify that the comparison terminates and produces the expected equality result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100