luk707 / luk707/filemanager

Delete directory doesn't exactly match the path provided

Open Beginner friendly
#73 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backend bug
Dominant language
TypeScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

## Description

When there is a directory in a workspace ie `testy`, and try to invoke delete_directory on the MinioFileRepository, passing a partial match ie `test`, the directory `testy` is deleted, which is not the intended action.

## Proposal

A possible solution is to iterate through objects in the workspace, and check for an exact match.

## AC

- If a directory ie `testy` exists, and delete_directory is invoked passing ie `test`, `testy` should **_not_** be deleted
- If `testy` is passed, it should be deleted
- A unit test to test this

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at MinioFileRepository.delete_directory and find the existing unit-test location for repository deletion behavior. Reproduce the partial-path case, then add coverage showing that only an exact directory path is deleted and run the relevant unit tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.