luckyframework / luckyframework/website

html2lucky doesn't convert script and style tags

Open
#920 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

html2lucky
Dominant language
Crystal
Stars
39
Forks
62
PR merge metrics
No merged PRs in 30d

Description

In this instance, I am just looking to convert some script tags for an analytics tool copy/pasta, but I need to write that by hand since it isn't convertible

## Test

Input:

```html
console.log("test")
h1 { color: red; }
```

Expected:
```crystal
# Whatever lucky html version of the above is
```

Actual:
```crystal
# empty
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing html2lucky with the provided script and style input, then locate the converter path that handles these tags. Check how the generated Lucky output is represented and add coverage for both tags; done means the input no longer produces empty output and the expected conversion is tested.

Written by the indexing model from the issue text.

Assessment

Tech stack
crystal, html
Domain
tooling, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.