luckyframework / luckyframework/lucky_flow
Move Lucky specific methods to a separate module
Nobody has claimed this yet.
- Dominant language
- Crystal
- Stars
- 55
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
Move these...
- https://github.com/luckyframework/lucky_flow/blob/b14b8645eb30d78d371c30c3f9a1be15dd403d01/src/lucky_flow.cr#L24-L37
- https://github.com/luckyframework/lucky_flow/blob/b14b8645eb30d78d371c30c3f9a1be15dd403d01/src/lucky_flow.cr#L59-L75
Into a module called LuckyFlow::LuckyHelpers
Will likely require splitting spec into Lucky specific tests.
There should also be a flag similar to what is done in Carbon: https://github.com/luckyframework/carbon/blob/master/README.md#development that let's you run specs with and without Lucky to ensure that it works for no matter what
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked sections of src/lucky_flow.cr at lines 24-37 and 59-75, then inspect the existing specs and the Carbon README development flag example. Separate the Lucky-specific specs, add LuckyFlow::LuckyHelpers, and provide a way to run the specs both with and without Lucky so both modes are verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100