luckyframework / luckyframework/lucky_flow
Add dependency on Lucky
Nobody has claimed this yet.
- Dominant language
- Crystal
- Stars
- 55
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
Related https://github.com/luckyframework/lucky_flow/issues/20
LuckyFlow was meant to be like Capybara which can be used with any framework or library so it does not have a dependency on Lucky. The problem is that there are still helpful methods added that use classes provided by Lucky and Avram but because the dependency is missing we can't actually use or test those methods because they don't exist from LuckyFlow's point of view.
I believe that we should go ahead and make that dependency explicit so that we can fully exploit that connection and test it correctly.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced sections in src/lucky_flow.cr and src/lucky_flow/expectations.cr, then inspect the repository's dependency configuration and existing tests. Add the explicit Lucky dependency and verify that the Lucky- and Avram-based methods can be used and tested correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100