luckyframework / luckyframework/lucky_cli

Enable CI for Windows

Open
#911 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted Windows
Dominant language
HTML
Stars
92
Forks
48
PR merge metrics
No merged PRs in 30d

Description

In https://github.com/luckyframework/lucky_cli/pull/906 I tried about 100 different times to get Windows to go green on the CI, and I was met with 100 different walls. For not Windows CI is disabled, but we will eventually need to get this added in.

Some of the issues I've run into:

* Can't use postgres as a `service` since containers don't run on Windows.
* Node isn't installed by default on Windows like it is for Mac and Linux
* Which also means yarn isn't installed by default...
* The [system_check fails](https://github.com/luckyframework/lucky_cli/issues/910) to run on Windows
* `yarn` is not a valid command error
* Can't find the `lucky` binary even after being added to PATH. Is it looking for `lucky.exe`?
* Windows supports different `shell` types like `pwsh`. Do we have to add duplicate commands for each step just on windows?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the CI changes and Windows failures discussed in PR #906, including the system_check issue in #910. Identify how PostgreSQL, Node, Yarn, the lucky binary, and shell commands behave on Windows; done means Windows CI runs successfully with those checks passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
crystal, github-actions, postgresql
Domain
ci-cd, cli, devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.