luckyframework / luckyframework/lucky_cli

Add a "remember me" option to SignInUser

Open
#784 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request hacktoberfest
Dominant language
HTML
Stars
92
Forks
48
PR merge metrics
No merged PRs in 30d

Description

I think it's fairly common to have some sort of "remember me?" option on login forms. I think we didn't add this in originally because it doesn't make much sense for Api-only apps. So if you're signing in through an API, then chances are that might be handled on the client side. Though, I could see a mobile app that gives you the option to stay logged in by checking a box as the "remember me" 🤔

In any case, I think it would be cool to add in by default.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the SignInUser implementation and reading how sign-in state is currently managed. Determine the intended API and behavior for a remember-me option, including how it should apply to API-only and mobile clients; the issue is done when that scope and its expected persistence behavior are defined and implemented.

Written by the indexing model from the issue text.

Assessment

Tech stack
crystal
Domain
authentication
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.