luckyframework / luckyframework/lucky_cli
CSRF should be removed if it's disabled in forms
Open
Nobody has claimed this yet.
good first issue
- Dominant language
- HTML
- Stars
- 92
- Forks
- 48
- PR merge metrics
- No merged PRs in 30d
Description
You have the option to disable CSRF in forms with
https://github.com/luckyframework/lucky/blob/60b24a8f0489d6115063d15ba5974481b02c9abe/src/lucky/tags/form_helpers.cr#L3
If this is disabled, then we should probably also display the metatags as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked form helper in src/lucky/tags/form_helpers.cr and the generated layout in src/components/shared/layout_head.cr. Trace how the disabled CSRF setting affects both the form and layout metadata, then verify that the generated output is consistent with that setting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal
- Domain
- security, web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100