luckyframework / luckyframework/lucky_cli
Rename SignIn to LogIn
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 92
- Forks
- 48
- PR merge metrics
- No merged PRs in 30d
Description
SignUp and SignIn are very similar and it takes a moment to figure out what they are doing, especially for non-native English speakers. We should use a different term for "creating an account". I think a common one is "Register" or just "Create Account"
* `SignUps::New/Create` -> `Registrations::New/Create`
* `SignUpUser` -> `RegisterUser`
Who uses this:
* etsy (sign in/register)
* google (sign in/create account)
* wikipedia (log in/create account)
* amazon (sign in/create account)
### Alternatives
Change `SignIn` to `LogIn` and keep `SignUp`
Who uses this nomenclature:
* facebook
* heroku
* reddit
* pinterest
* wikipedia (log in/create account)
* stackoverflow
* netlify identity widget (log in/sign up)
I'm leaning toward Sign In -> Log In
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the generated application's SignUps::New/Create and SignUpUser references, then review the alternatives and discussion in this issue before choosing terminology. Done means reaching agreement on one naming scheme and updating every affected generated reference consistently; the issue does not identify files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal
- Domain
- authentication, cli
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100