luckyframework / luckyframework/lucky
Rename dont_report in Error actions
Nobody has claimed this yet.
- Dominant language
- Crystal
- Stars
- 2.7k
- Forks
- 172
- PR merge metrics
- No merged PRs in 30d
Description
No one has actually brought this up, but I would imagine that since this is an English contraction missing the punctuation, it may be a little confusing for non-english speakers. I think we can just call it ignore_report or skip_report or something like that...
To avoid a breaking change, we can add whatever the new method name is, then deprecate the old one.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the dont_report definition and its usages in the error actions API. Choose a replacement such as ignore_report or skip_report, retain dont_report as a deprecated compatibility name, and verify that existing references and tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100