luckyframework / luckyframework/lucky

Consider ServerSentEvents over WebSockets?

Open
#1,666 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Crystal
Stars
2.7k
Forks
172
PR merge metrics
No merged PRs in 30d

Description

I just saw this article https://germano.dev/sse-websockets/ I need to read it a bit more and really understand it, but overall the concept seems fairly straight forward. It made me think.... what if Lucky just implemented SSE out of the box instead of the traditional websocket handler option like I was attempting in https://github.com/luckyframework/lucky/pull/1305 🤔

So far using https://github.com/cable-cr/cable with Lucky has been awesome for websocket usage. I haven't worked on that other PR because there really isn't much of a need, and it's a pretty complex area. But if we could get something built-in that's a lot easier to understand and use, maybe it's a better alternative?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked SSE-versus-WebSockets article and the discussion in pull request #1305, then review how Lucky currently integrates cable-cr for WebSockets. The issue does not specify an entry point, tests, API, or acceptance criteria, so the intended built-in SSE design and definition of done need to be established first.

Written by the indexing model from the issue text.

Assessment

Tech stack
crystal
Domain
backend, web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.