luckyframework / luckyframework/lucky

HTTP/2 headers should all be lowercase

Open
#1,060 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

easy/high impact
Dominant language
Crystal
Stars
2.7k
Forks
172
PR merge metrics
No merged PRs in 30d

Description

According to the HTTP/2 spec, all headers should be lowercase.

Currently crystal handles checking against lowercase vs uppercase, and dashes vs underscores, so CONTENT_TYPE is the same as content-type. We could safely lowercase, and dasherize for convention any place that we mention a header key directly.

This also makes me curious to know what else we would need to do to ensure we fully support HTTP/2? 🤔

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by tracing where Lucky checks and emits HTTP header keys, then compare those paths with the HTTP/2 specification linked in the issue. Done means header keys are consistently lowercase and conventionally dasherized without breaking existing header lookups; broader HTTP/2 support is not scoped.

Written by the indexing model from the issue text.

Assessment

Tech stack
crystal
Domain
backend, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.