luckyframework / luckyframework/carbon
Send result
Nobody has claimed this yet.
- Dominant language
- Crystal
- Stars
- 87
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
Hi, I'm using carbon with smtp adapter.
How can I get the result of sending a message?
Method "deliver" return useless **"{"221", ["2.0.0 Closing connecton"]}"**
Email client returns true or false
https://github.com/arcage/crystal-email/blob/2f6ee366e6fd2ea24ed1df484eaab39e19ffdc0b/src/email/client.cr#L186
Maybe it's worth returning this result from the adapter and this method?https://github.com/luckyframework/carbon/blob/d7d9b3004098c850d6b9d3d310f6b2d72a8a5b1a/src/carbon/email.cr#L133
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/carbon/email.cr at the referenced deliver method and compare it with src/email/client.cr at the linked line to understand the SMTP adapter's current return value. Trace the adapter result through deliver and add or update the relevant tests so the returned value reflects the email client's success result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100