luckyframework / luckyframework/carbon
The layout filename should include the content type
Open
Nobody has claimed this yet.
- Dominant language
- Crystal
- Stars
- 87
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
Related: https://github.com/luckyframework/carbon/issues/76
Instead of generating layout.ecr, it should look more like layout.html.ecr; however, if we change the naming, then this really become layout/your_layout_name.html.ecr
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/carbon/email.cr around line 60 and review related issue #76 for the naming context. Trace how the layout filename is generated, then verify that generated layouts include the content type and preserve the layout name path described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100