luckyframework / luckyframework/carbon
Consider changing how the layout is defined
Nobody has claimed this yet.
- Dominant language
- Crystal
- Stars
- 87
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
Per @paulcsmith
> I would have expected this to be the name of the file and not the folder. May be worth changing this so the default is always src/emails/templates/layouts/{file} and the layout is the name of the file, not the folder. I think that is more common in most languages and that way you have one folder with all your layouts rather than a folder for each kind of layout
In reference to specifying a layout like `layout my_email_layout`
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the layout resolution entry point for `layout my_email_layout`; the issue does not name a file or test. Check how the current folder-based layout is selected, then verify that the default path uses `src/emails/templates/layouts/{file}` and treats the layout name as a file name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100