luckyframework / luckyframework/avram
Rename User::BaseQuery to just User::Query
Open
Nobody has claimed this yet.
- Dominant language
- Crystal
- Stars
- 183
- Forks
- 67
- PR merge metrics
- No merged PRs in 30d
Description
Since we have User::SaveOperation and User::DeleteOperation, it seems weird that we provide BaseQuery and not just Query.
To avoid immediate breaking changes, we could provide an alias pointing to BaseQuery still.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the definitions and usages of User::BaseQuery in the repository, then inspect nearby tests for query classes. Confirm the intended User::Query name and preserve User::BaseQuery as an alias; done means the new name works without breaking the existing name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal
- Domain
- database
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100