luckyframework / luckyframework/avram
Avram::Migrator::Runner.cmd_args does not parse sockets
Open
Nobody has claimed this yet.
- Dominant language
- Crystal
- Stars
- 183
- Forks
- 67
- PR merge metrics
- No merged PRs in 30d
Description
When no hostname is specified, the query_params' `host` should be parsed and used as host instead.
This adds support for sockets
https://github.com/will/crystal-pg/pull/241/files#diff-1fd3eeb2041dc73ed667bfcf61a3a66bbbe388fed786360a38ab49894daf5440R71
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Avram::Migrator::Runner.cmd_args and compare its host handling with the linked crystal-pg pull request. Verify that when no hostname is supplied, query_params' host is used so socket connections are parsed correctly; the issue does not mention a test file, so confirm the behavior through the relevant migrator argument path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal, postgresql
- Domain
- database
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100