luckyframework / luckyframework/avram

Avram queries need .collate(String)

Open
#740 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Crystal
Stars
183
Forks
67
PR merge metrics
No merged PRs in 30d

Description

Currently, one can only do COLLATE using the `.where()` operator, which is supposed to only be an escape hatch for handling the incompleteness of the current query set. The Postgres syntax for COLLATE demands double-quotes around the locale string (`"en_US"`, `"POSIX"`, etc.), so the way that `where()` passes the second and subsequent arguments in single-quotes won't work.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named in the issue. Start by locating Avram's query-building entry points and the existing where() handling, then compare how PostgreSQL COLLATE values are emitted. Done means queries expose a collate(String) method that produces valid quoted locale syntax.

Written by the indexing model from the issue text.

Assessment

Tech stack
crystal, postgresql
Domain
database
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.