luckyframework / luckyframework/avram

Query-related events don't include the name of the query class

Open
#647 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Crystal
Stars
183
Forks
67
PR merge metrics
No merged PRs in 30d

Description

All of the operation-related events contain the name of the operation but the query events don't.

Operation event example: https://github.com/luckyframework/avram/blob/5e29f75371dca5a2bc16858163dc3790cabfbfcb/src/avram/events/delete_failed_event.cr#L5

Events needing the query class name:
- https://github.com/luckyframework/avram/blob/5e29f75371dca5a2bc16858163dc3790cabfbfcb/src/avram/events/query_event.cr#L4
- https://github.com/luckyframework/avram/blob/5e29f75371dca5a2bc16858163dc3790cabfbfcb/src/avram/events/failed_query_event.cr#L4

Contributor guide

Open the contributing guide

Research direction

Start by comparing src/avram/events/query_event.cr and src/avram/events/failed_query_event.cr with src/avram/events/delete_failed_event.cr, which demonstrates the expected operation name. Update the query events so they include the query class name, then verify that both event payloads expose it consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
crystal
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.