luckyframework / luckyframework/avram

Nested SaveOperation has_one doesn't account for needs

Open
#618 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Crystal
Stars
183
Forks
67
PR merge metrics
No merged PRs in 30d

Description

If you have a nested SaveOperation, and use the `has_one` declaration, it won't account for `needs` on that nested SaveOperation.

Right now, we just pass in `params` to the top operation, and that gets passed down. To do this, we may either need a refactor of how the nested stuff works, or add in some new syntax. One suggestion I'd be cool with seeing is maybe the `has_one` creates a `needs` on the parent that passes in a NamedTuple

```crystal
class SaveParent < Parent::SaveOperation
has_one child : SaveChild
end

SaveParent.create(params, child: {...}) do |o, p|
end
```

Then in this example, if the `SaveChild` has `needs` or whatever, that can be explicitly specified. If the `SaveChild` doesn't have `needs`, then maybe it's just empty? Type safety gets a little foggy with that.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing nested SaveOperation handling for a has_one declaration and how params are passed from the parent operation to the nested operation. Compare that flow with how needs are declared and supplied. Done means a nested SaveChild can receive its needs through SaveParent while preserving clear type-safe behavior for children with or without needs.

Written by the indexing model from the issue text.

Assessment

Tech stack
crystal
Domain
database
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.