luckyframework / luckyframework/avram
Remove the file_attribute macro
Open
Nobody has claimed this yet.
BREAKING CHANGE
- Dominant language
- Crystal
- Stars
- 183
- Forks
- 67
- PR merge metrics
- No merged PRs in 30d
Description
With the changes in https://github.com/luckyframework/avram/commit/b44793857899a06b4c3b9d45cdd60f0164ec9fd9 the only thing file_attribute does is specify the type for you. Because I would prefer being able to define any type for an attribute this feels like a special case we shouldn't handle.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/avram/define_attribute.cr at lines 91-97 and search the repository for file_attribute usages and related tests. Done means the macro and its special-case handling are removed without leaving broken references, while attributes can use explicitly defined types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- crystal
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100